Skip to content

Commit

Permalink
YES is gone, we're using Uninferable for quite some time now
Browse files Browse the repository at this point in the history
  • Loading branch information
PCManticore committed Oct 10, 2018
1 parent 6fbb463 commit 36fa294
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 5 deletions.
2 changes: 1 addition & 1 deletion astroid/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@
from astroid.node_classes import are_exclusive, unpack_infer
from astroid.scoped_nodes import builtin_lookup
from astroid.builder import parse, extract_node
from astroid.util import Uninferable, YES
from astroid.util import Uninferable

# make a manager instance (borg) accessible from astroid package
from astroid.manager import AstroidManager
Expand Down
4 changes: 0 additions & 4 deletions astroid/util.py
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,3 @@ def limit_inference(iterator, size):
if has_more is not False:
yield Uninferable
return


# Backwards-compatibility aliases
YES = Uninferable

2 comments on commit 36fa294

@clintonb
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This broke pylint-django: pylint-dev/pylint-django#201.

Does Astroid follow semantic versioning? If so, this change should not have been in the 2.0 -> 2.1 upgrade since it is backwards-incompatible.

@PCManticore
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes was a super old alias of Inferrable, if I recall correctly we used to emit a deprecation warning about it. regardless feel free to ping pylint-django to upgrade to Uninferrable instead.

Please sign in to comment.