-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Capitalize plane keys in Tfs class #47
Comments
- capitalize plane letter in file naming for consistency accross pylhc packages - change hardcoded test input file names according to the new behavior - change hardcoded test expected results according to the new behavior - bump tfs-pandas version as 2.0.0 as discussed today
- Bump version to 2.0.0 - Update dependency to python >= 3.7 for pylhc packages consistency (see acc-py stack) - Removed unused test dependencies - Removed setup_requires as it is deprecated - Reworked setup.py to be consistent with that of pylhc/omc3 - Some formatting
…fsDataFrame repr and avoid shadowing built-in "id" in _dtype_to_str
Worst case scenario, if pandas decides to change this private api then only our tests will suffer but not the package in itself
Not in the file, names, right? |
…ized or lowered without access issues
Small write-up here so that it's always clear: When a TfsCollection includes two planes, the attributes are appended with the plane keys (so we get, say, Previously the The chosen implementation (see commit 37844ba later on corrected in dfbc675) uses This is behavior is now also tested in
This was my mistake. |
…gers are found, in hopes that it teaches windows not to default to a C-compatible 32bits integer Additional: - Include comment lines in tfs test files to ensure testing their detection (and ignoring them) - Add logging.error statements before raising exceptions to leave traces in log files if traceback view is not an option (htcondor etc)
added tests for coverage and raises (incl. test inputs)
…ferring the types conversion to an outer version Additional: - rename tools' logger to LOGGER for consistency - some formatting
As agreed verbally: - notify in changelog that fixedtfs has been remove - upgrade pytest-cov dependency to >=2.9, which explicitely guarantees python 3.8 compatibility on PyPI - test coverage for a not implemented method in TfsCollection We have checked that omc3 tests run fine with tfs 2.0.0 (code from this PR) :)
- include objects non-loading in changelog - remove commented out lines in doc/conf.py - type hint and docstring in handler
To improve consistency among our packages capitalize the plane keys for "planed" data frames, i.e.
("X", "Y")
instead of("x", "y")
.Requires change of
_define_property_two_planes(args, kwargs)
.The text was updated successfully, but these errors were encountered: