Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for job dependencies #132

Merged
merged 10 commits into from
Oct 13, 2022
Merged

Allow for job dependencies #132

merged 10 commits into from
Oct 13, 2022

Conversation

niklassiemer
Copy link
Member

Momentan 'nur' für slurm

@niklassiemer
Copy link
Member Author

ping @jan-janssen

Introduce and use Base SchedulerCommands class
@jan-janssen jan-janssen added the format_black reformat the code using the black standard label Oct 13, 2022
@@ -83,6 +85,11 @@ def command_line(argv):
mode_status = True
elif opt in ("-l", "--list"):
mode_list = True
elif opt in ("-b", "--dependency"):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if -b is the best choice for dependencies. But as I do not have a better suggestion either as -d is already in use for delete, I am fine with this.

Copy link
Member

@jan-janssen jan-janssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@jan-janssen
Copy link
Member

ping @jan-janssen

I am sorry for the delay, somehow this slipped through.

@jan-janssen jan-janssen merged commit cec56f3 into master Oct 13, 2022
@delete-merged-branch delete-merged-branch bot deleted the dependencies branch October 13, 2022 20:17
@niklassiemer
Copy link
Member Author

Nevermind, this was not pressing for me :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
format_black reformat the code using the black standard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants