Write output from submission to file on error #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This may happen if the queuing system e.g. refused to schedule a run because of errors in the submission script
jan-janssen
reviewed
Apr 22, 2022
| @@ -422,7 +422,9 @@ def _execute_command( | |||
| universal_newlines=True, | |||
| shell=not isinstance(commands, list), | |||
| ) | |||
| except subprocess.CalledProcessError: | |||
| except subprocess.CalledProcessError as e: | |||
| with open(os.path.join(working_directory, "pysqa.err"), "w") as f: | |||
There was a problem hiding this comment.
Should it be a write or an append? And should we name the file pysqa.log instead?
There was a problem hiding this comment.
My assumption was that in each directory pysqa only submits one job. If that's not true we should probably use propper logging. I have no opinion on the filename though, I can change that.
There was a problem hiding this comment.
Ok, you are right - the file should only be written once. And naming the file pysqa.err is also fine for me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may happen if the queuing system e.g. refused to schedule a run
because of errors in the submission script.
This came up for me because I asked for too much memory by mistake. It might be worthwhile to add a
memory_maxoption to the queue yaml.I have not checked the other adapters in detail, but it seems at least the
RemoteQueueAdapterseems to suffer the same problem.