Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can run right away #96

Merged
merged 3 commits into from
Nov 30, 2023
Merged

Can run right away #96

merged 3 commits into from
Nov 30, 2023

Conversation

liamhuber
Copy link
Member

Introduces a new metaclass that adds a __post__ method to classes which is invoked after __init__ and with the same input. This is leveraged to allow Node and its children to run at the end of instantiation (defaults to false, don't run).

Closes #42

Copy link

Binder 👈 Launch a binder notebook on branch pyiron/pyiron_workflow/can_run_right_away

Copy link

Pull Request Test Coverage Report for Build 7040004718

  • 19 of 19 (100.0%) changed or added relevant lines in 6 files are covered.
  • 57 unchanged lines in 6 files lost coverage.
  • Overall coverage increased (+0.05%) to 88.564%

Files with Coverage Reduction New Missed Lines %
util.py 1 97.37%
macro.py 4 89.83%
workflow.py 4 82.93%
function.py 10 92.35%
node.py 18 89.96%
composite.py 20 88.06%
Totals Coverage Status
Change from base Build 7039638449: 0.05%
Covered Lines: 3485
Relevant Lines: 3935

💛 - Coveralls

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.09% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (b9b706a) 1996 1645 82.42%
Head commit (39dca4b) 2006 (+10) 1655 (+10) 82.50% (+0.09%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#96) 14 14 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@liamhuber liamhuber merged commit e3bbec5 into main Nov 30, 2023
17 of 18 checks passed
@liamhuber liamhuber deleted the can_run_right_away branch November 30, 2023 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Let nodes run on instantiation
1 participant