Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose a subset of graphviz.Graph.render options inside Node.draw #94

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

liamhuber
Copy link
Member

Now you can optionally save the rendered graph in the node's working directory (by default) right when you make the .draw() call.

Closes #41

Copy link

Binder 👈 Launch a binder notebook on branch pyiron/pyiron_workflow/draw_more

@coveralls
Copy link

coveralls commented Nov 29, 2023

Pull Request Test Coverage Report for Build 7039563774

  • 11 of 18 (61.11%) changed or added relevant lines in 1 file are covered.
  • 24 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+2.5%) to 88.517%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pyiron_workflow/node.py 11 18 61.11%
Files with Coverage Reduction New Missed Lines %
pyiron_workflow/node.py 4 94.43%
node.py 20 89.84%
Totals Coverage Status
Change from base Build 7014940719: 2.5%
Covered Lines: 3469
Relevant Lines: 3919

💛 - Coveralls

Copy link

codacy-production bot commented Nov 29, 2023

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+3.52% (target: -1.00%) 85.71%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (4487bb3) 1990 1570 78.90%
Head commit (c99e381) 1996 (+6) 1645 (+75) 82.42% (+3.52%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#94) 7 6 85.71%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@liamhuber liamhuber added the format_black trigger the Black formatting bot label Nov 29, 2023
@liamhuber liamhuber merged commit b9b706a into main Nov 29, 2023
16 of 17 checks passed
@liamhuber liamhuber deleted the draw_more branch November 29, 2023 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
format_black trigger the Black formatting bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more options to .draw()
3 participants