You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just adds to_list() methods to DotDict and DataIO so the dictionaries can be case to value lists. The order is explicitly not guaranteed, but it winds up being the order items are added to the underlying dict.
======================================================================
ERROR: test_connection (unit.test_io.TestDataIO.test_connection)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/runner/work/pyiron_workflow/pyiron_workflow/tests/unit/test_io.py", line 68, in test_connection
self.input.x = self.input.y
^^^^^^^^^^^^
File "/home/runner/work/pyiron_workflow/pyiron_workflow/pyiron_workflow/io.py", line 76, in __setattr__
self._assign_value_to_existing_channel(self.channel_dict[key], value)
File "/home/runner/work/pyiron_workflow/pyiron_workflow/pyiron_workflow/io.py", line 92, in _assign_value_to_existing_channel
channel.connect(value.channel)
File "/home/runner/work/pyiron_workflow/pyiron_workflow/pyiron_workflow/channels.py", line 126, in connect
raise ChannelConnectionError(
pyiron_workflow.channels.ChannelConnectionError: x (InputData) and y (InputData) share a generic type but were not a valid connection. Check channel classes, type hints, etc.
Riiight. Because the two tests each had the same name, only one of them was getting run and it wasn't this one. This actually does break expectations -- trying to assign input to input should raise an error.
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just adds
to_list()
methods toDotDict
andDataIO
so the dictionaries can be case to value lists. The order is explicitly not guaranteed, but it winds up being the order items are added to the underlying dict.As requested in #38.
Closes #40.