By default, be picker about callable #546
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
typeguard.check_type
is quite relaxed when seeing if something iscallable
-- so much so that everything will pass through, evencheck_type(5, callable)
, or (as in the test suite) a check against an instance of a class that has not defined__call__
. This switches the default behaviour oftype_hinting.valid_value
to convert rawcallable
hints intocollections.abc.Callable
, whichcheck_type
treats more rigorously. I believe this is closer to the intuitively expected behaviour ofvalid_value
, but the original behaviour can still be recovered via a flag argument.@XzzX, I only noticed this because of #545, so thanks for pushing that!