Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unnecessary explicit instantiations #543

Merged
merged 1 commit into from
Jan 14, 2025
Merged

fix unnecessary explicit instantiations #543

merged 1 commit into from
Jan 14, 2025

Conversation

XzzX
Copy link
Contributor

@XzzX XzzX commented Jan 14, 2025

Many functions can directly take generators. We do not need to explicitly instantiate lists, etc before passing them to the functions. Also use generator expressions where possible.

Enables and fixes ruff C4 checks.

Copy link

Binder 👈 Launch a binder notebook on branch pyiron/pyiron_workflow/ruff-c4

Copy link

codacy-production bot commented Jan 14, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 88.89%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (6aed9fe) 3356 3070 91.48%
Head commit (7a37ce0) 3356 (+0) 3070 (+0) 91.48% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#543) 9 8 88.89%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@coveralls
Copy link

coveralls commented Jan 14, 2025

Pull Request Test Coverage Report for Build 12764719503

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 91.478%

Files with Coverage Reduction New Missed Lines %
type_hinting.py 1 97.73%
Totals Coverage Status
Change from base Build 12757933620: 0.0%
Covered Lines: 3070
Relevant Lines: 3356

💛 - Coveralls

Copy link
Member

@liamhuber liamhuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super, LGTM 🚀

@liamhuber liamhuber merged commit 53a5c14 into main Jan 14, 2025
21 checks passed
@liamhuber liamhuber deleted the ruff-c4 branch January 14, 2025 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants