Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mypy compliance #533

Merged
merged 45 commits into from
Jan 18, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
ff3226b
Use typing.Callable instead of callable
liamhuber Jan 7, 2025
5b7e9c7
Ignore erroneous error
liamhuber Jan 7, 2025
aa3c143
Hint a tuple, don't return one
liamhuber Jan 7, 2025
534a2c6
Hint typing.Callable instead of callable
liamhuber Jan 7, 2025
85f95d2
Expose the Self typing tool for all versions
liamhuber Jan 8, 2025
9895187
Add a mypy job
liamhuber Jan 8, 2025
c594760
`mypy` channels (#534)
liamhuber Jan 8, 2025
6279797
Move Ruff jobs into the main push-pull script
liamhuber Jan 8, 2025
e13caf5
Ruff: import Callable from collections.abc
liamhuber Jan 8, 2025
4d242b6
black
liamhuber Jan 8, 2025
71c46da
Drop the private type hint (#535)
liamhuber Jan 9, 2025
214c6e2
`mypy` channels redux (#536)
liamhuber Jan 10, 2025
fc41dfa
Apply hints to IO panels (#537)
liamhuber Jan 10, 2025
c77bcbd
Refactor connection validity
liamhuber Jan 10, 2025
ff6a984
`mypy` run (#541)
liamhuber Jan 11, 2025
3577158
`mypy` topology and find (#542)
liamhuber Jan 11, 2025
3e8c92f
Merge pull request #540 from pyiron/valid_connection_refactor
XzzX Jan 13, 2025
801bddb
Merge branch 'main' into mypy
liamhuber Jan 14, 2025
9c260dd
`mypy` semantics (#538)
liamhuber Jan 16, 2025
acc8739
Semantics generic parent (#544)
liamhuber Jan 16, 2025
7942910
Improvements to semantic labeling (#547)
liamhuber Jan 16, 2025
52fe191
Make the `HasChannel` interface generic on the `Channel` type (#550)
liamhuber Jan 17, 2025
4c9af5e
Generic `HasIO` classes to specify data output panel types (#551)
liamhuber Jan 17, 2025
2b9f550
`mypy` draw (#555)
liamhuber Jan 17, 2025
eeeb65d
Generic value receiver (#556)
liamhuber Jan 17, 2025
c2269b8
Hint attribute
liamhuber Jan 17, 2025
1e2ab80
Don't reuse variable
liamhuber Jan 17, 2025
309433b
Only hint available backends
liamhuber Jan 17, 2025
9c46954
Cast docstrings to string
liamhuber Jan 17, 2025
70295ec
Hint NotData class
liamhuber Jan 17, 2025
12458e3
Just use classmethod
liamhuber Jan 17, 2025
de767fa
Ruff fix imports
liamhuber Jan 17, 2025
ba29c55
Remove preview helper method (#557)
liamhuber Jan 17, 2025
4f05f6e
Relax Node.emitting_channels hint
liamhuber Jan 17, 2025
f6ea024
Account for __doc__ possibly being None
liamhuber Jan 17, 2025
2240e98
Be more specific in return hint
liamhuber Jan 17, 2025
44d68b2
Change return on Composite.remove_child (#558)
liamhuber Jan 17, 2025
b09d0ef
IO maps (#559)
liamhuber Jan 17, 2025
e61a9db
Reverse instance check
liamhuber Jan 17, 2025
8907842
Return both nodes on replacement (#560)
liamhuber Jan 17, 2025
fcb341a
Hint graph creator
liamhuber Jan 17, 2025
e3d1ada
Don't reuse variable
liamhuber Jan 17, 2025
1b3baae
Don't reuse variable here either
liamhuber Jan 17, 2025
3d1143e
`mypy` for_loop (#561)
liamhuber Jan 18, 2025
e36409b
`mypy` finishing touches (#562)
liamhuber Jan 18, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions .github/workflows/push-pull.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,3 +19,34 @@ jobs:
alternate-tests-env-files: .ci_support/lower_bound.yml
alternate-tests-python-version: '3.10'
alternate-tests-dir: tests/unit

mypy:
runs-on: ubuntu-latest
steps:
- name: Setup Python
uses: actions/setup-python@v5
with:
python-version: "3.12"
architecture: x64
- name: Checkout
uses: actions/checkout@v4
- name: Install mypy
run: pip install mypy
- name: Test
run: mypy --ignore-missing-imports ${{ github.event.repository.name }}

ruff-check:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: astral-sh/ruff-action@v1
with:
args: check

ruff-sort-imports:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- uses: astral-sh/ruff-action@v1
with:
args: check --select I --fix --diff
17 changes: 0 additions & 17 deletions .github/workflows/ruff.yml

This file was deleted.

Loading
Loading