Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add semantikon #530

Closed
wants to merge 2 commits into from
Closed

Add semantikon #530

wants to merge 2 commits into from

Conversation

samwaseda
Copy link
Member

I added only semantikon here, because I needed a git environment to try out different ontology ideas, so I would simply open stacked draft PR's on top of this one (or feel free to simply merge this one). Alternatively you can also give me a write permission in pyiron_ontology and I'll do the development there.

Copy link

github-actions bot commented Jan 2, 2025

Binder 👈 Launch a binder notebook on branch pyiron/pyiron_workflow/add_semantikon

Copy link

codacy-production bot commented Jan 2, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (913a03f) 3377 3090 91.50%
Head commit (1408ab7) 3377 (+0) 3090 (+0) 91.50% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#530) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Copy link

github-actions bot commented Jan 2, 2025

Pull Request Test Coverage Report for Build 12587991213

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.501%

Totals Coverage Status
Change from base Build 12575310840: 0.0%
Covered Lines: 3090
Relevant Lines: 3377

💛 - Coveralls

@niklassiemer
Copy link
Member

I was not aware of this issue, I added the ontology team to the pyiron_ontology repo with maintainer access.

@samwaseda
Copy link
Member Author

I was not aware of this issue, I added the ontology team to the pyiron_ontology repo with maintainer access.

ok then I'm gonna do my development there. Thanks!

P.S. Feel free to merge or close this PR @liamhuber

@liamhuber
Copy link
Member

I'll close for now. I didn't realize you were missing write access in pyiron_ontology either, so thanks for fixing that Niklas!

@liamhuber liamhuber closed this Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants