Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[patch] Fix typos in dict-like type hints #516

Merged
merged 1 commit into from
Nov 30, 2024
Merged

Conversation

liamhuber
Copy link
Member

I.e. dict[str, object] not dict[str:object], as observed by @XzzX in #514

I.e. dict[str, object] not dict[str:object].
@liamhuber liamhuber changed the title Fix typos in dict-like type hints [patch] Fix typos in dict-like type hints Nov 30, 2024
Copy link

Binder 👈 Launch a binder notebook on branch pyiron/pyiron_workflow/dict_type_hint_typos

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (8dcb67a) 3377 3090 91.50%
Head commit (340f21d) 3377 (+0) 3090 (+0) 91.50% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#516) 2 2 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@coveralls
Copy link

Pull Request Test Coverage Report for Build 12092244838

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.501%

Totals Coverage Status
Change from base Build 12091579592: 0.0%
Covered Lines: 3090
Relevant Lines: 3377

💛 - Coveralls

@liamhuber liamhuber merged commit 913a03f into main Nov 30, 2024
18 checks passed
@liamhuber liamhuber deleted the dict_type_hint_typos branch November 30, 2024 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants