Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[patch] 🔥 🐛 remove semantic children from the state on __setstate__ #372

Merged
merged 1 commit into from
Jun 25, 2024

Conversation

liamhuber
Copy link
Member

This is the inverse operation to adding them to the state in getstate. Without this, in the subsequent super call, all these children wind up in dict.

This is the inverse operation to adding them to the state in __getstate__. Without this, in the subsequent super call, all these children wind up in __dict__.
Copy link

Binder 👈 Launch a binder notebook on branch pyiron/pyiron_workflow/semantic_parent_state_bug

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (6c092c4) 3456 3192 92.36%
Head commit (5b78a81) 3456 (+0) 3192 (+0) 92.36% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#372) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences


🚀 Don’t miss a bit, follow what’s new on Codacy.

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@coveralls
Copy link

coveralls commented Jun 25, 2024

Pull Request Test Coverage Report for Build 9669747852

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 92.361%

Totals Coverage Status
Change from base Build 9636974428: 0.0%
Covered Lines: 3192
Relevant Lines: 3456

💛 - Coveralls

@liamhuber liamhuber merged commit 3a3b3ee into main Jun 25, 2024
18 checks passed
@liamhuber liamhuber deleted the semantic_parent_state_bug branch June 25, 2024 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants