Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[minor] Make macro output labels a class attribute #269

Merged
merged 3 commits into from
Apr 11, 2024

Conversation

liamhuber
Copy link
Member

Minimal changes to remove output_labels from the signature of AbstractMacro and make these a class property (_provided_output_labels), just like in AbstractFunction.

Non-goals:

  • Refactoring the shared functionality between AbstractMacro and AbstractFunction out into a mixin

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link

Binder 👈 Launch a binder notebook on branch pyiron/pyiron_workflow/macro_output_labels_to_classattr

Copy link

codacy-production bot commented Mar 28, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.05% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (98d4570) 3418 2999 87.74%
Head commit (14064ea) 3420 (+2) 2999 (+0) 87.69% (-0.05%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#269) 11 11 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

@liamhuber
Copy link
Member Author

 ======================================================================
FAIL: test_draw (test_node.TestNode.test_draw) [Testing with format pdf]
----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\a\pyiron_workflow\pyiron_workflow\tests\unit\test_node.py", line 326, in test_draw
    with self.assertRaises(
AssertionError: CalledProcessError not raised : Graphviz doesn't seem to be happy about the combindation PDF format and Windows right now. We throw a warning for it in `Node.draw`, so if this test ever fails and this combination _doesn't_ fail, remove this extra bit of testing and remove the warning.

Looks like upstream might have patched windows already...

@liamhuber liamhuber added the format_black trigger the Black formatting bot label Mar 28, 2024
@liamhuber liamhuber mentioned this pull request Mar 28, 2024
11 tasks
@liamhuber liamhuber changed the title Make macro output labels a class attribute [minor] Make macro output labels a class attribute Mar 28, 2024
Base automatically changed from class_channel_specs to main April 11, 2024 20:13
@liamhuber liamhuber merged commit 7d14985 into main Apr 11, 2024
14 of 15 checks passed
@liamhuber liamhuber deleted the macro_output_labels_to_classattr branch April 11, 2024 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
format_black trigger the Black formatting bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants