-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[minor] Make Function
IO info available at the class level
#266
Conversation
So channel labels and type hints (and later any ontological hints) can be viewed without ever instantiating a node. That means `output_labels` is no longer available at the class instance level, but only when defining a new class!
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesYou may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation |
Windows unit tests failed with
Doesn't look directly related to these changes, but I might need to go back and pin graphviz to some other version. |
This was much easier because we never need to inspect the source code manually (as we do sometimes to check return values).
Function
IO info available at the class levelFunction
IO info available at the class level
Yyyep. ======================================================================
ERROR: test_draw (test_node.TestNode.test_draw)
----------------------------------------------------------------------
Traceback (most recent call last):
File "C:\Miniconda3\envs\my-env\Lib\site-packages\graphviz\backend\execute.py", line 88, in run_check
proc.check_returncode()
File "C:\Miniconda3\envs\my-env\Lib\subprocess.py", line 502, in check_returncode
raise CalledProcessError(self.returncode, self.args, self.stdout,
subprocess.CalledProcessError: Command '[WindowsPath('dot'), '-Kdot', '-Tpdf', '-O', 'start_graph']' returned non-zero exit status 1. |
Windows error needs to be fixed, but it's from graphviz and unrelated to these changes. |
Just some housekeeping in the files we're touching anyhow
This will be useful for building nodes that take other node classes as input and want to build their own corresponding IO based on that class's IO without having to instantiate it first. It also borders on necessary for the long-term goal of being able to suggest nodes to users based on ontological (or regular...) type hints ala
ironflow
.Example:
Tasks:
Non-goals:
Macro
, which makes sense but is left to another PRWorkflow
, which doesn't make sense since its IO is dynamic anyhowMinor bump as the signature for
AbstractFunction
has changed.