Transfer workflow files #2
Conversation
Namely, on_run should be a property returning a callable
They are not implemented and working yet, so at least fail cleanly!
And downstream stuff like `update` and thus `__call__`. This was requested by Joerg and now makes things really start to feel like regular python
We may wish to later make Macro's slow, but for Workflows, since the IO is just routing through to the owned nodes, input updates are _anyhow_ most of the time re-running things, so it's a sensible default IMO
Just a first pass
Excessive granularity can't hurt us, so always pass something >0 and don't bother with overriding the method
There are unreasonable dependency bugs when I include pympipool, so since the executor stuff needs to be redone anyhow, just kill it all.
…ansfer_workflow_files
|
Well, purging I tried tracking down why |
|
Nope, it wasn't the cache. I just pinned maggma over in ironflow, so let's see if that smokes out the offender. |
|
Tests hang now for an hour. This is also a problem I encounter with pympipool when I run tests in pycharm on my macbook. Since my primary objective right now is just to get functioning workflow module moved over to this repository, I'm going to revert to using |
pympipool seems to work ok in the notebook, but hangs on my macbook and it looks like on the CI too
Of course, I'm an idiot, I moved this here because the dependencies were not playing well with other parts of pyiron_contrib to start with. That will be resolved separately soon, but for now just move on. I'll repo-transfer the executor code and history over. |
… into transfer_executor
Transfer executor
Including git history. I found this helpful in the process.