Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canonically scoped labels for channels #120

Merged
merged 3 commits into from
Dec 7, 2023
Merged

Conversation

liamhuber
Copy link
Member

Closes #116

We still string-code the "__" in examples, but I think that's OK since I expect users to be writing this stuff out in their maps anyhow, only #86 will really help that.

The while-loop meta node still uses "__" manually, but in a different context so I'm leaving it.

This is to improve the robustness of the design by reducing the use of hard-coded strings
Unrelated to this PR, but a small change to make adjacent to what I'm already doing
Copy link

github-actions bot commented Dec 7, 2023

Binder 👈 Launch a binder notebook on branch pyiron/pyiron_workflow/canonically_scoped_names

Copy link

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.01% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (20f7b85) 2195 1844 84.01%
Head commit (3eed68e) 2196 (+1) 1845 (+1) 84.02% (+0.01%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#120) 6 6 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

Copy link

github-actions bot commented Dec 7, 2023

Pull Request Test Coverage Report for Build 7133014409

  • 6 of 6 (100.0%) changed or added relevant lines in 2 files are covered.
  • 12 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 89.307%

Files with Coverage Reduction New Missed Lines %
channels.py 12 93.12%
Totals Coverage Status
Change from base Build 7132993571: 0.0%
Covered Lines: 3892
Relevant Lines: 4358

💛 - Coveralls

@liamhuber liamhuber merged commit c2a0419 into main Dec 7, 2023
17 checks passed
@liamhuber liamhuber deleted the canonically_scoped_names branch December 7, 2023 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Formalize the channel naming convention
1 participant