Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overwrote compress function to exclude all .yace files #163

Closed
wants to merge 1 commit into from

Conversation

HaithamGaafer
Copy link
Contributor

Also made the pacemaker job to compress by default after it's done while excluding .yace files

Also made the pacemaker job to compress by default after it's done while excluding `.yace` files
@HaithamGaafer HaithamGaafer requested a review from pmrv October 25, 2024 18:45
Copy link

Binder 👈 Launch a binder notebook on branch pyiron/pyiron_potentialfit/compress_function-1

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11523723264

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 82 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.004%) to 3.765%

Files with Coverage Reduction New Missed Lines %
pacemaker/job.py 82 0.0%
Totals Coverage Status
Change from base Build 11388784028: -0.004%
Covered Lines: 193
Relevant Lines: 5126

💛 - Coveralls

Copy link
Collaborator

@pmrv pmrv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's not urgent, I'd like to wait for this PR, otherwise go ahead an merge.

"""
if files_to_compress is None:
files_to_compress = [f for f in self.files.list() if not f.endswith('.yace')]
super(PacemakerJob, self).compress(files_to_compress=files_to_compress)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
super(PacemakerJob, self).compress(files_to_compress=files_to_compress)
super().compress(files_to_compress=files_to_compress)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants