-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Readthedocs render #36
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesYou may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation |
The class diagrams don't render, and the API documentation is not triggering |
API docs are working, but the mermaid diagrams are still not rendering |
Just in case that possibly makes a difference...
Ugh, it looks even worse now |
Ok, the readthedocs logs have the following line: |
I saw in the logs I was getting a "WARNING: command 'mmdc' cannot be run (needed for mermaid output), check the mermaid_cmd setting" warning. I found some random github issue suggesting that the mermaid cli needs to be involved, and then had the pragmatic idea to just go do whatever the sphinxcontrib-mermaid folks are doing for _their_ readthedocs because it's obviously working for them! Sure enough, they install the mermaid cli on readthedocs. Let's try it.
I found some random github issue suggesting that the mermaid cli needs to be involved, and then had the pragmatic idea to just go do whatever the sphinxcontrib-mermaid folks are doing for their readthedocs because it's obviously working for them! Sure enough, they install the mermaid cli on readthedocs. Let's try it. |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesYou may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation |
Because I was too dumb to just [read the docs](https://sphinxcontrib-mermaid-demo.readthedocs.io/en/latest/) to begin with
The readthedocs log has the following error:
|
Forcing the output type to PNG worked...or I just needed to re-run; either way the build is correctly showing the diagrams. Be careful as the failure may re-occur: there are reports of the upstream puppeteer as the root of the timeout error: |
Actually, the error is still showing up in the raw readthedocs log, but the image is showing in the final rendered docs nonetheless... |
Use the pyiron logo
By forcing the thumbnail size to be super small
Using it is already handled in the conf!
Add rtd theme to dependencies
Add example notebooks to docs
The build doesn't crash, but it's not showing the content either. For starters, let's add the
myst
dependency, which should be needed for rendering the markdown file.