Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pyiron-data to the notebooks dependency #30

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Conversation

liamhuber
Copy link
Member

Which I expect to resolve the following failure in the notebooks CI:

File /usr/share/miniconda3/envs/my-env/lib/python3.11/site-packages/pyiron_atomistics/atomistics/job/potentials.py:154, in PotentialAbstract._get_potential_df(plugin_name, file_name_lst, backward_compatibility_name)
    152     return pandas.concat(df_lst)
    153 else:
--> 154     raise ValueError("Was not able to locate the potential files.")

ValueError: Was not able to locate the potential files.

Copy link

Binder 👈 Launch a binder notebook on branch pyiron/pyiron_ontology/data_dependency

Copy link

codacy-production bot commented Jan 11, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (a3b9766) 0 0 87.31%
Head commit (768debe) 457 (+457) 399 (+399) 87.31% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#30) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

You may notice some variations in coverage metrics with the latest Coverage engine update. For more details, visit the documentation

@liamhuber liamhuber merged commit 3979e58 into main Jan 11, 2024
18 checks passed
@liamhuber liamhuber deleted the data_dependency branch January 11, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants