Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lpatch tinydata #962

Merged
merged 5 commits into from
Jan 16, 2024
Merged

Lpatch tinydata #962

merged 5 commits into from
Jan 16, 2024

Conversation

liamhuber
Copy link
Member

Patching test failures on #949

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Contributor

Binder 👈 Launch a binder notebook on branch pyiron/pyiron_contrib/lpatch_tinydata

@liamhuber
Copy link
Member Author

Notebook tests are just hanging (>30mins).

In pyiron_workflow, pympipool requires a modification of the path so that the unit tests can be found... perhaps something similar is happening here with the notebooks? @jan-janssen, as far as I can see the pympipool tests never run the example notebook there, so maybe you have some insight on this.

For now I'm just going try-and-see by getting rid of pympipool from the notebook.

@liamhuber liamhuber requested a review from pmrv January 16, 2024 00:22
@liamhuber
Copy link
Member Author

Windows and notebooks runs are both still going after 12 minutes 👎

@liamhuber
Copy link
Member Author

Windows took a while (20 mins) but finished. Notebooks got through checkout but were "pending" on the actual run for over an hour

Copy link
Contributor

@pmrv pmrv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@liamhuber liamhuber merged commit 169a4e2 into tinydata Jan 16, 2024
14 of 15 checks passed
@liamhuber liamhuber deleted the lpatch_tinydata branch January 16, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants