Include pyiron-data in the dependencies

[jan-janssen]

No description provided.

[github-actions]

👈 Launch a binder notebook on branch pyiron/pyiron_contrib/pyiron-data

[coveralls]

Pull Request Test Coverage Report for Build 6472511406

• 0 of 0 changed or added relevant lines in 0 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage remained the same at 16.94%

---

Totals
Change from base Build 6439924633:	0.0%
Covered Lines:	2518
Relevant Lines:	14864

---

💛 - Coveralls

[liamhuber]

@jan-janssen just FYI, with repos using the centralized CI you only need to update the dependency in .ci_support/environement.yml and a bot will take care of docs and binder. Of course no harm is caused doing it manually either, I'm just trying to sell pyiron/actions a little 😉

[github-advanced-security]

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

[liamhuber]

Indeed, tests run fine with pyiron-data explicitly included.

[jan-janssen]

@liamhuber I do not understand why you closed this pull request, as it fixes the current issue until we have a better solution.

[liamhuber]

@liamhuber I do not understand why you closed this pull request, as it fixes the current issue until we have a better solution.

Just because I wanted the little red X's to act as a burning fire under our butts to solve the real problem 😝 Also I hope that it's fixed so fast that there's no point in merging and then reverting this change, and since Niklas now opened a fixing PR upstream I think this will be the case.

As long as no releases have been made since the daily tests started failing (and they haven't) there is no harm to users. It's then inconvenient only for people doing dev work on contrib because the CI erroneously fails; but since we split a bunch of packages off recently this mostly just impacts the dependabot. If you want to merge it to get the dependabot some ✅ I have no objection, but I also don't mind waiting until the pyiron_atomistics PR gets merged.

[jan-janssen]

Only include pyiron-data in the notebooks environment #893