Qol workflow reprs #658
Merged
Qol workflow reprs #658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm looking at you, Atoms class
For some reason the _repr_json_ method is getting automatically triggered for `Node` and `Channel`, but _not_ for `Workflow` and `IO`. Until I can figure out why and fix it, let's just give users easy access to a manual workaround
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Pull Request Test Coverage Report for Build 4865619290
💛 - Coveralls |
niklassiemer
reviewed
May 3, 2023
| def info(self): | ||
| print(dumps(self.to_dict(), indent=2)) | ||
|
|
||
| def repr_json(self): |
There was a problem hiding this comment.
There shoud be a repr_json or similar method used in notebooks to Display the object automatically as json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to_dictdictionary, which avoids errors when trying to view, e.g., channels that hold anAtomsobject. A different solution will be needed for actual serialization, but this works fine for display purposes.WorkflowandIOsomehow aren't getting their pretty JSON representation triggered, even thoughNodeandChanneldo and they all just inherit this functionality fromHasToDict. Until I can figure out why and fix it, I added a methodjson_repr()to force this behaviour.