Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI problems #1116

Closed
wants to merge 33 commits into from
Closed

Fix CI problems #1116

wants to merge 33 commits into from

Conversation

samwaseda
Copy link
Member

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

Binder 👈 Launch a binder notebook on branch pyiron/pyiron_contrib/fix_tests

@coveralls
Copy link

coveralls commented Jul 31, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 10181743190

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage remained the same at 12.641%
Files with Coverage Reduction New Missed Lines %
atomistics/elastic/elastic.py 1 90.91%
Totals Coverage Status
Change from base Build 10047509574: 0.0%
Covered Lines: 1280
Relevant Lines: 10126
💛 - Coveralls

@samwaseda
Copy link
Member Author

I don’t understand why it’s happening:

AttributeError: 'ShellOutput' object has no attribute 'energy_pot'

It’s coming from Lammps.ipynb, but I cannot reproduce it in my environment. Do you have an idea? @pmrv

@samwaseda
Copy link
Member Author

So in the end instead of solving the problem apparently I made more problems. Now, we got also the problem with coveralls and pycp2k which pip says is not available on the system. I’ll try to look into it tomorrow since it’s late now…

samwaseda and others added 14 commits August 1, 2024 06:29
@samwaseda
Rename push-pull
f0c3042
@samwaseda
ok it looks like it was a mistake
4618c4f
@samwaseda
I'm a loss
5f927d0
@samwaseda
ok it was a version problem
5f95ba2
@samwaseda
there was no b
ae228b0
@pyiron-runner
[dependabot skip] Update env file
3e7c3cb
@samwaseda
update all yml files
923a711
@samwaseda
Merge branch 'fix_tests' of github.com:pyiron/pyiron_contrib into fix…
cfd3cea 
…_tests
@samwaseda
downgrade pycp2k to see what happens
791533a
@pyiron-runner
[dependabot skip] Update env file
fe46072
@samwaseda
set back because this cannot have been the reason
8e9ddf2
@samwaseda
Merge branch 'fix_tests' of github.com:pyiron/pyiron_contrib into fix…
3f0ef98 
…_tests
@pyiron-runner
[dependabot skip] Update env file
46a29cc
@pmrv
Update lammps notebook
d675eac 
The example resource wants to use lmp, but lammps conda package provides lmp_mpi only.
Maybe that changed recently?

Also updated the notebook to not hard code my own filesystem paths
anymore. Oops.
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@samwaseda samwaseda changed the title Add only empty lines to see where the errors are coming from Fix CI problems Aug 2, 2024
@pmrv
Copy link
Contributor

pmrv commented Aug 2, 2024

#1119 should take care of this, at least the CI runs again.

@pmrv pmrv closed this Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@samwaseda @coveralls @pmrv @pyiron-runner