Skip to content
This repository has been archived by the owner on Nov 27, 2024. It is now read-only.

remove matplotlib.docstring #215

Merged
merged 7 commits into from
Oct 20, 2023
Merged

remove matplotlib.docstring #215

merged 7 commits into from
Oct 20, 2023

Conversation

samwaseda
Copy link
Member

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@samwaseda
Copy link
Member Author

I don't really understand why the tests are failing...

@delete-merged-branch delete-merged-branch bot deleted the remove_matplotlib_docstring branch October 20, 2023 05:17
@jan-janssen jan-janssen restored the remove_matplotlib_docstring branch October 20, 2023 06:36
@jan-janssen jan-janssen reopened this Oct 20, 2023
@jan-janssen
Copy link
Member

======================================================================
ERROR: test_takes_scalar_field (test_mesh.TestDecorators)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/pyiron_continuum/pyiron_continuum/tests/unit/test_mesh.py", line 56, in test_takes_scalar_field
    self.assertRaises(TypeError, method, self.mesh, "not even numeric")  # Duh
  File "/usr/share/miniconda3/envs/test/lib/python3.10/unittest/case.py", line 738, in assertRaises
    return context.handle('assertRaises', args, kwargs)
  File "/usr/share/miniconda3/envs/test/lib/python3.10/unittest/case.py", line 201, in handle
    callable_obj(*args, **kwargs)
  File "/home/runner/work/pyiron_continuum/pyiron_continuum/pyiron_continuum/mesh.py", line 39, in wrapper
    if np.all(scalar_field.shape == self.divisions):
ValueError: operands could not be broadcast together with shapes (3,) (0,) 

----------------------------------------------------------------------

@jan-janssen
Copy link
Member

@liamhuber Can you take a look art this issue? It seems to be related to the RectMesh class. Currently this issue blocks the update of the docker containers pyiron/docker-stacks#131 which are required for the MaterialDigital project.

@jan-janssen jan-janssen merged commit 34caeb3 into main Oct 20, 2023
@delete-merged-branch delete-merged-branch bot deleted the remove_matplotlib_docstring branch October 20, 2023 07:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants