Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Files: Fix windows compatibility #1643

Merged
merged 4 commits into from
Sep 16, 2024
Merged

Files: Fix windows compatibility #1643

merged 4 commits into from
Sep 16, 2024

Conversation

jan-janssen
Copy link
Member

@jan-janssen jan-janssen commented Sep 13, 2024

======================================================================
FAIL: test_load_guess_group (sphinx.test_base.TestSphinx.test_load_guess_group)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\a\pyiron_base\pyiron_atomistics\tests\sphinx\test_base.py", line 452, in test_load_guess_group
    self.assertEqual(guess.rho.file, '"' + rho_file + '"')
AssertionError: '"C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\tmp0wjq4yqz\\rho.sxb"' != '"C:\\Users\\RUNNER~1\\AppData\\Local\\Temp\\tmp0wjq4yqz/rho.sxb"'
- "C:\Users\RUNNER~1\AppData\Local\Temp\tmp0wjq4yqz\rho.sxb"
?                                                  ^
+ "C:\Users\RUNNER~1\AppData\Local\Temp\tmp0wjq4yqz/rho.sxb"
?                                                  ^


======================================================================
FAIL: test_run_complete (vasp.test_vasp.TestVasp.test_run_complete)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\a\pyiron_base\pyiron_atomistics\tests\vasp\test_vasp.py", line 423, in test_run_complete
    self.assertTrue(
AssertionError: False is not true

----------------------------------------------------------------------

@jan-janssen jan-janssen added the integration Start the integration tests with pyiron_atomistics/contrib for this PR label Sep 13, 2024
@jan-janssen jan-janssen reopened this Sep 15, 2024
@jan-janssen
Copy link
Member Author

======================================================================
FAIL: test_run_complete (vasp.test_vasp.TestVasp.test_run_complete)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\a\pyiron_base\pyiron_atomistics\tests\vasp\test_vasp.py", line 423, in test_run_complete
    self.assertTrue(
AssertionError: False is not true
----------------------------------------------------------------------

@jan-janssen
Copy link
Member Author

The issue was partially fixed by updating the tests in pyiron_atomistics in pyiron/pyiron_atomistics#1563 and pyiron/pyiron_atomistics#1564

@jan-janssen jan-janssen merged commit 1c4df01 into main Sep 16, 2024
28 checks passed
@jan-janssen jan-janssen deleted the integration branch September 16, 2024 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration Start the integration tests with pyiron_atomistics/contrib for this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant