Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix project mv #1615

Merged
merged 1 commit into from
Aug 22, 2024
Merged

Fix project mv #1615

merged 1 commit into from
Aug 22, 2024

Conversation

jan-janssen
Copy link
Member

@jan-janssen jan-janssen commented Aug 22, 2024 •
edited
Loading

The issue was that the command line utility uses the Project from pyiron_base while the job has a Project from pyiron_atomistics. I inverted the isinstance() comparison, this is not nice but it works.

@jan-janssen jan-janssen linked an issue Aug 22, 2024 that may be closed by this pull request
error in pyiron mv #1614
Closed
@jan-janssen jan-janssen requested a review from pmrv August 22, 2024 13:09
@jan-janssen jan-janssen merged commit 0f5293d into main Aug 22, 2024
25 checks passed
@jan-janssen jan-janssen deleted the project_mv branch August 22, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmrv pmrv pmrv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

error in pyiron mv
2 participants
@jan-janssen @pmrv