Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression on #1188 #1336

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Fix regression on #1188 #1336

merged 1 commit into from
Feb 14, 2024

Conversation

pmrv
Copy link
Contributor

@pmrv pmrv commented Feb 14, 2024

A refactor in between must have missed renaming the variable that the check is using, essentially making it always False.

#1188

A refactor in between must have missed renaming the variable that the check is using, essentially
making it always False.
@pmrv pmrv added the bug Something isn't working label Feb 14, 2024
Copy link
Member

@jan-janssen jan-janssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@pmrv pmrv merged commit 1e610aa into main Feb 14, 2024
28 checks passed
@pmrv pmrv deleted the importclass branch February 14, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants