Do not import pint when it is not needed #1314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # pyiron_base/project/generic.py
niklassiemer
reviewed
Feb 7, 2024
There was a problem hiding this comment.
I am ok with the changes in general, especially for such a rare used case the recreation of the function is fine with me. However, I wonder if we could not simply do something like
def _size_conversion(size: "pint.Quantity"):
import pint
...and leave the function where it was?
I do not think that python typing allows defining types as strings. |
|
@niklassiemer I moved the function to a separate module, this way it can still be imported when somebody wants to use it somewhere else but it is not imported by default. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.