Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use proper monotonic clock for benchmark #1235

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Use proper monotonic clock for benchmark #1235

merged 1 commit into from
Dec 5, 2023

Conversation

pmrv
Copy link
Contributor

@pmrv pmrv commented Nov 30, 2023

No description provided.

@pmrv pmrv requested a review from liamhuber November 30, 2023 19:48
liamhuber
liamhuber approved these changes Nov 30, 2023
View reviewed changes
Copy link
Member

@liamhuber liamhuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Did you ctrl+f for time throughout? The only improvement to this pr that I can think of is just to make sure we make the same good change everywhere possible

@pmrv
Copy link
Contributor Author

pmrv commented Nov 30, 2023

Looks good.

Did you ctrl+f for time throughout? The only improvement to this pr that I can think of is just to make sure we make the same good change everywhere possible

Ah, I had not done that. I'll give it a check in the office tomorrow.

@pmrv
Copy link
Contributor Author

pmrv commented Dec 5, 2023

Looks good.
Did you ctrl+f for time throughout? The only improvement to this pr that I can think of is just to make sure we make the same good change everywhere possible

Ah, I had not done that. I'll give it a check in the office tomorrow.

Seems that this is the only occurrence. The benchmark tests use timeit.

@pmrv pmrv merged commit e6cca77 into main Dec 5, 2023
22 checks passed
@delete-merged-branch delete-merged-branch bot deleted the pmrv-patch-1 branch December 5, 2023 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liamhuber liamhuber liamhuber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pmrv @liamhuber