Merge pull request #1327 from pyiron/test_remove_job

Add test for remove_job and remove additional query for job_id

pyiron_base/project/generic.py

@@ -1202,8 +1202,7 @@ def remove_job(self, job_specifier, _unprotect=False):
                     state.logger.debug(
                         "hdf file does not exist. Removal from database will be attempted."
                     )
-                    job_id = self.get_job_id(job_specifier)
-                    self.db.delete_item(job_id)
+                    self.db.delete_item(job.job_id)
             else:
                 raise EnvironmentError("copy_to: is not available in Viewermode !")
 

tests/job/test_genericJob.py

@@ -474,6 +474,18 @@ def test_compress(self):
         self.assertEqual(len(wd_files), 1, "Only one zipped file should be present in the working directory")
         self.assertEqual(wd_files[0], f"{job.name}.tar.bz2", "Inconsistent name for the zipped file")
 
+    def test_remove_job(self):
+        job = self.project.create_job(ReturnCodeJob, "job_without_hdf5")
+        job.run()
+        self.assertTrue(isinstance(job.job_id, int))
+        self.assertTrue(os.path.isfile(job.project_hdf5.file_name))
+        os.remove(job.project_hdf5.file_name)
+        with open(job.project_hdf5.file_name, "w") as f:
+            f.writelines(["wrong file"])
+        self.assertTrue(os.path.isfile(job.project_hdf5.file_name))
+        self.project.remove_job(job_specifier=job.job_name)
+        self.assertIsNone(self.project.load(job_specifier=job.job_name))
+
     def test_restart(self):
         wd_warn_key = "write_work_dir_warnings"
         previous_wd_warn_setting = self.project.state.settings.configuration[