Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store VASP volumes as numpy arrays #546

Merged
merged 3 commits into from
Feb 22, 2022
Merged

Store VASP volumes as numpy arrays #546

merged 3 commits into from
Feb 22, 2022

Conversation

sudarsan-surendralal
Copy link
Member

Currently they're stored as lists

@sudarsan-surendralal sudarsan-surendralal added the bug Something isn't working label Feb 22, 2022
@sudarsan-surendralal sudarsan-surendralal linked an issue Feb 22, 2022 that may be closed by this pull request
VASP - job["output/generic/volume"] - is a list #545
Closed
@coveralls
Copy link

coveralls commented Feb 22, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 1882071797

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 70.216%
Totals Coverage Status
Change from base Build 1875443801: 0.0%
Covered Lines: 11684
Relevant Lines: 16640
💛 - Coveralls

@sudarsan-surendralal sudarsan-surendralal added the format_black reformat the code using the black standard label Feb 22, 2022
jan-janssen
jan-janssen approved these changes Feb 22, 2022
View reviewed changes
Copy link
Member

@jan-janssen jan-janssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@sudarsan-surendralal sudarsan-surendralal merged commit bc32bd0 into master Feb 22, 2022
@delete-merged-branch delete-merged-branch bot deleted the vasp_vol branch February 22, 2022 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-janssen jan-janssen jan-janssen approved these changes

Assignees
No one assigned
Labels
bug Something isn't working format_black reformat the code using the black standard
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VASP - job["output/generic/volume"] - is a list
4 participants
@sudarsan-surendralal @coveralls @jan-janssen @pyiron-runner