Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove _QhullUser import #527

Merged
merged 1 commit into from
Feb 8, 2022
Merged

Remove _QhullUser import #527

merged 1 commit into from
Feb 8, 2022

Conversation

niklassiemer
Copy link
Member

I love type hints, however, not if we have to reach to a private class of a private module.

@niklassiemer
Remove _QhullUser import
434bc40 
I love type hints, however, not if we have to reach to a private class of a private module.
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1808652232

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.009%) to 70.202%
Totals Coverage Status
Change from base Build 1806970675: -0.009%
Covered Lines: 11669
Relevant Lines: 16622
💛 - Coveralls

jan-janssen
jan-janssen approved these changes Feb 7, 2022
View reviewed changes
Copy link
Member

@jan-janssen jan-janssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@niklassiemer niklassiemer merged commit dc2bdfd into master Feb 8, 2022
@delete-merged-branch delete-merged-branch bot deleted the rm_QhullUser branch February 8, 2022 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-janssen jan-janssen jan-janssen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@niklassiemer @coveralls @jan-janssen