Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Decrease convergence goal #479

Merged
merged 4 commits into from
Dec 14, 2021
Merged

Decrease convergence goal #479

merged 4 commits into from
Dec 14, 2021

Conversation

jan-janssen
Copy link
Member

No description provided.

This was referenced Dec 14, 2021
Closed
Closed
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1579091280

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 70.051%
Totals Coverage Status
Change from base Build 1578658974: 0.0%
Covered Lines: 11550
Relevant Lines: 16488
💛 - Coveralls

liamhuber
liamhuber approved these changes Dec 14, 2021
View reviewed changes
Copy link
Member

@liamhuber liamhuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't hurt. These tests are already annoyingly slow on my local machine anyway, and I don't see that we lose anything with this.

@jan-janssen jan-janssen merged commit 54da368 into master Dec 14, 2021
@delete-merged-branch delete-merged-branch bot deleted the decrease_convergence_goal branch December 14, 2021 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liamhuber liamhuber liamhuber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jan-janssen @coveralls @liamhuber