Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make NeighborTrajectory simpler #445

Merged
merged 5 commits into from
Dec 1, 2021
Merged

Make NeighborTrajectory simpler #445

merged 5 commits into from
Dec 1, 2021

Conversation

pmrv
Copy link
Contributor

@pmrv pmrv commented Nov 26, 2021

Pending #444.

@pmrv pmrv added the enhancement New feature or request label Nov 26, 2021
@pmrv pmrv marked this pull request as ready for review November 30, 2021 08:32
Co-authored-by: Sudarsan Surendralal <[email protected]>
@pmrv
Copy link
Contributor Author

pmrv commented Dec 1, 2021

Thanks @sudarsan-surendralal I've been sloppy. :S

@pmrv pmrv merged commit 18d8356 into master Dec 1, 2021
@delete-merged-branch delete-merged-branch bot deleted the simpletraj branch December 1, 2021 14:15
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1526011310

  • 16 of 22 (72.73%) changed or added relevant lines in 1 file are covered.
  • 1075 unchanged lines in 30 files lost coverage.
  • Overall coverage decreased (-0.02%) to 69.827%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pyiron_atomistics/atomistics/structure/neighbors.py 16 22 72.73%
Files with Coverage Reduction New Missed Lines %
pyiron_atomistics/atomistics/structure/factories/aimsgb.py 1 94.74%
pyiron_atomistics/atomistics/structure/phonopy.py 2 56.0%
pyiron_atomistics/atomistics/structure/analyse.py 3 98.48%
pyiron_atomistics/sphinx/potential.py 3 66.67%
pyiron_atomistics/atomistics/structure/factories/ase.py 4 90.91%
pyiron_atomistics/interactive/activation_relaxation_technique.py 4 95.56%
pyiron_atomistics/atomistics/generic/object_type.py 5 58.62%
pyiron_atomistics/atomistics/job/atomistic.py 6 72.77%
pyiron_atomistics/atomistics/structure/pyscal.py 6 87.1%
pyiron_atomistics/atomistics/structure/symmetry.py 6 93.14%
Totals Coverage Status
Change from base Build 1519855178: -0.02%
Covered Lines: 11430
Relevant Lines: 16369

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants