Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add clear error when calling animate_structure on empty job #442

Merged
merged 1 commit into from
Nov 26, 2021
Merged

Add clear error when calling animate_structure on empty job #442

merged 1 commit into from
Nov 26, 2021

Conversation

pmrv
Copy link
Contributor

@pmrv pmrv commented Nov 25, 2021

Otherwise this fails deep in nglview and is incomprehensible to users

@pmrv
Add clear error when calling animate_structure on empty job
18606cf 
Otherwise this fails deep in nglview and is incomprehensible to users
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1504586775

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.009%) to 69.799%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pyiron_atomistics/atomistics/job/atomistic.py 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
pyiron_atomistics/atomistics/job/atomistic.py 1 72.87%
Totals Coverage Status
Change from base Build 1500854841: -0.009%
Covered Lines: 11440
Relevant Lines: 16390
💛 - Coveralls

@pmrv pmrv merged commit 42d2b8a into master Nov 26, 2021
@delete-merged-branch delete-merged-branch bot deleted the animate-error branch November 26, 2021 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pmrv @coveralls