Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Water interactive fix #366

Merged
merged 3 commits into from
Sep 24, 2021
Merged

Water interactive fix #366

merged 3 commits into from
Sep 24, 2021

Conversation

sudarsan-surendralal
Copy link
Member

Fix crashing interactive water notebooks

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@github-actions github-actions bot added the integration Start the notebook integration tests for this PR label Sep 23, 2021
@sudarsan-surendralal sudarsan-surendralal added integration Start the notebook integration tests for this PR and removed integration Start the notebook integration tests for this PR labels Sep 23, 2021
@coveralls
Copy link

coveralls commented Sep 23, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1268432368

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.004%) to 68.16%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pyiron_atomistics/lammps/interactive.py 0 1 0.0%
Totals Coverage Status
Change from base Build 1265203378: -0.004%
Covered Lines: 11121
Relevant Lines: 16316
💛 - Coveralls

@jan-janssen
Merge pull request #368 from pyiron/master
f4e2ae5 
Merge pull request #365 from pyiron/style_full_without_bonds
jan-janssen
jan-janssen approved these changes Sep 24, 2021
View reviewed changes
Copy link
Member

@jan-janssen jan-janssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@jan-janssen jan-janssen merged commit c9520e6 into master Sep 24, 2021
@delete-merged-branch delete-merged-branch bot deleted the water_interactive branch September 24, 2021 04:42
@sudarsan-surendralal sudarsan-surendralal mentioned this pull request Sep 24, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-janssen jan-janssen jan-janssen approved these changes

@pmrv pmrv Awaiting requested review from pmrv

Assignees
No one assigned
Labels
integration Start the notebook integration tests for this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sudarsan-surendralal @coveralls @jan-janssen