-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Strain #328
Conversation
Pull Request Test Coverage Report for Build 1197250093
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strains
class has unit tests outstanding.
Otherwise a few nits, but the functionality seems great and I have no complaints about the overall architecture. As soon as the unit tests are there (and it's PEP8 linted!!!) I'm happy.
Co-authored-by: Liam Huber <[email protected]>
Co-authored-by: Liam Huber <[email protected]>
So now I finally installed a PEP8 plugin (which I'll hopefully regularly use from now on) so it should be fine :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made some formatting suggestions to play nice with sphinx, but looks good otherwise!
Co-authored-by: Marvin Poul <[email protected]>
Co-authored-by: Marvin Poul <[email protected]>
Co-authored-by: Marvin Poul <[email protected]>
Calculation of local strain.
Example: