Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interactive units #295

Merged
merged 12 commits into from
Aug 6, 2021
Merged

Interactive units #295

merged 12 commits into from
Aug 6, 2021

Conversation

sudarsan-surendralal
Copy link
Member

Ensures that unit conversions are proper even for interactive jobs

@sudarsan-surendralal sudarsan-surendralal added the bug Something isn't working label Jul 28, 2021
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@coveralls
Copy link

coveralls commented Jul 28, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1079334855

  • 14 of 36 (38.89%) changed or added relevant lines in 2 files are covered.
  • 15 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.04%) to 68.033%
Changes Missing Coverage Covered Lines Changed/Added Lines %
pyiron_atomistics/lammps/base.py 13 15 86.67%
pyiron_atomistics/lammps/interactive.py 1 21 4.76%
Files with Coverage Reduction New Missed Lines %
pyiron_atomistics/atomistics/master/murnaghan.py 2 71.77%
pyiron_atomistics/lammps/interactive.py 6 34.98%
pyiron_atomistics/vasp/outcar.py 7 90.34%
Totals Coverage Status
Change from base Build 1071749957: -0.04%
Covered Lines: 10920
Relevant Lines: 16051
💛 - Coveralls

@sudarsan-surendralal
Copy link
Member Author

@jan-janssen shall I merge this for now?

@sudarsan-surendralal sudarsan-surendralal merged commit b5b92da into master Aug 6, 2021
@delete-merged-branch delete-merged-branch bot deleted the interactive_units branch August 6, 2021 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jan-janssen jan-janssen jan-janssen left review comments

@samwaseda samwaseda Awaiting requested review from samwaseda

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sudarsan-surendralal @coveralls @jan-janssen