Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix: Handle empty indices #284

Merged
merged 3 commits into from
Aug 6, 2021
Merged

Hotfix: Handle empty indices #284

merged 3 commits into from
Aug 6, 2021

Conversation

sudarsan-surendralal
Copy link
Member

No description provided.

@sudarsan-surendralal sudarsan-surendralal added the bug Something isn't working label Jul 21, 2021
@samwaseda
Copy link
Member

Shouldn't the same apply to self._cells? This being said I don't really understand why self._indices is allowed to be None.

@coveralls
Copy link

coveralls commented Jul 21, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1075134619

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • 367 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.04%) to 68.073%
Files with Coverage Reduction New Missed Lines %
pyiron_atomistics/atomistics/master/murnaghan.py 9 72.21%
pyiron_atomistics/atomistics/structure/periodic_table.py 26 83.5%
pyiron_atomistics/atomistics/job/atomistic.py 30 73.26%
pyiron_atomistics/atomistics/structure/atoms.py 302 73.97%
Totals Coverage Status
Change from base Build 1049244167: 0.04%
Covered Lines: 10910
Relevant Lines: 16027
💛 - Coveralls

@sudarsan-surendralal
Copy link
Member Author

Shouldn't the same apply to self._cells? This being said I don't really understand why self._indices is allowed to be None.

You're right! It's the cells that need to be handled this way, the indices are never None. This was an issue with my subclass!

@sudarsan-surendralal
Copy link
Member Author

@samwaseda Shall I merge this now?

@sudarsan-surendralal sudarsan-surendralal merged commit 707c52f into master Aug 6, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix_traj_ind branch August 6, 2021 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samwaseda samwaseda Awaiting requested review from samwaseda

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sudarsan-surendralal @samwaseda @coveralls