Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new class to calculate electronic F from DFT #1583

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Add new class to calculate electronic F from DFT #1583

wants to merge 2 commits into from

Conversation

pmrv
Copy link
Contributor

@pmrv pmrv commented Oct 10, 2024

The new class FermiSmearing is accessible via

job.get_electronic_structure().fermi

for all GenericDFTJobs. it calculates the free energy of the electronic system and can output it as a pandas dataframe. It also calculates the density at the fermi level for comparison with the Sommerfeld method, though the method itself is not implemented.

The new class FermiSmearing is accessible via

job.get_electronic_structure().fermi

for all GenericDFTJobs.  it calculates the free energy of the electronic
system and can output it as a pandas dataframe.  It also calculates the
density at the fermi level for comparison with the Sommerfeld method,
though the method itself is not implemented.
@pmrv pmrv requested a review from samwaseda October 10, 2024 09:35
@coveralls
Copy link

coveralls commented Oct 10, 2024

Pull Request Test Coverage Report for Build 11271403413

Details

  • 28 of 75 (37.33%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.2%) to 70.732%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pyiron_atomistics/dft/waves/electronic.py 28 75 37.33%
Totals Coverage Status
Change from base Build 11228629848: -0.2%
Covered Lines: 10805
Relevant Lines: 15276

💛 - Coveralls

@jan-janssen
Copy link
Member

Looks good to me - Can you add a test?

@jan-janssen jan-janssen marked this pull request as draft December 17, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants