Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to sphinx log file parsing and spin detection #1568

Merged
merged 2 commits into from
Sep 18, 2024

Conversation

skatnagallu
Copy link
Contributor

Fixes the issues 1 and 4 mentioned here .

@coveralls
Copy link

Pull Request Test Coverage Report for Build 10901950445

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 70.897%

Totals Coverage Status
Change from base Build 10896531720: 0.0%
Covered Lines: 10777
Relevant Lines: 15201

💛 - Coveralls

@skatnagallu
Copy link
Contributor Author

@samwaseda If you give a thumbs up I would like to merge this

Copy link
Member

@samwaseda samwaseda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I forgot! Looks perfect to me!

@skatnagallu skatnagallu merged commit b1f555d into main Sep 18, 2024
24 checks passed
@skatnagallu skatnagallu deleted the sphinx_log_parser branch September 18, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants