-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use ResourceResolvers in lammps/vasp/sphinx #1527
Conversation
Pull Request Test Coverage Report for Build 10417795334Details
💛 - Coveralls |
Test failure was due to the backwards version testing. I've updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it passes the integration tests I'm fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Otherwise we do not get to import the resolvers.
base 0.9.12 needs the resolvers as well, so it makes no sense to have this bound lower.
This requires a new class attribute resource_plugin_name, so that it does not have to passed to _get_resolver anymore
for more information, see https://pre-commit.ci
Like I wrote in #1528 and I added those commits here now as well. @jan-janssen Is changing |
Updating the |
Minimal changes to make atomistics use the resolvers. See #1528 for clean up.