Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delay NGLview import #1474

Merged
merged 2 commits into from
Jul 1, 2024
Merged

Delay NGLview import #1474

merged 2 commits into from
Jul 1, 2024

Conversation

jan-janssen
Copy link
Member

No description provided.

@jan-janssen jan-janssen added the format_black reformat the code using the black standard label Jun 30, 2024
@coveralls
Copy link

coveralls commented Jun 30, 2024

Pull Request Test Coverage Report for Build 9734770024

Details

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 96 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 71.067%

Files with Coverage Reduction New Missed Lines %
pyiron_atomistics/atomistics/structure/atoms.py 96 73.22%
Totals Coverage Status
Change from base Build 9683374437: 0.0%
Covered Lines: 10687
Relevant Lines: 15038

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 1, 2024

Pull Request Test Coverage Report for Build 9734787265

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.067%

Totals Coverage Status
Change from base Build 9683374437: 0.0%
Covered Lines: 10687
Relevant Lines: 15038

💛 - Coveralls

Copy link
Member

@niklassiemer niklassiemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jan-janssen jan-janssen merged commit fe156a8 into main Jul 1, 2024
24 checks passed
@jan-janssen jan-janssen deleted the delayed_nglview branch July 1, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
format_black reformat the code using the black standard
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants