Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change index error in electronic structure to warning #1459

Merged
merged 1 commit into from
Jun 21, 2024

Conversation

samwaseda
Copy link
Member

ElectronicStructure tends to be extremely vulnerable whenever the job is aborted. As there is no one currently working on it, I replace error by warning

@samwaseda samwaseda added the minor add functionality in a backward compatible manner label Jun 20, 2024
@coveralls
Copy link

coveralls commented Jun 20, 2024

Pull Request Test Coverage Report for Build 9593390505

Details

  • 4 of 6 (66.67%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.008%) to 71.174%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pyiron_atomistics/sphinx/base.py 4 6 66.67%
Totals Coverage Status
Change from base Build 9488265420: -0.008%
Covered Lines: 10684
Relevant Lines: 15011

💛 - Coveralls

Copy link
Member

@jan-janssen jan-janssen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. @samwaseda Do you plan to merge this pull request today? I would like to release a new pyiron_atomistics version.

@samwaseda samwaseda merged commit d94f596 into main Jun 21, 2024
27 of 28 checks passed
@samwaseda samwaseda deleted the safer_electronic_structure branch June 21, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor add functionality in a backward compatible manner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants