-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional inputs to phonopy #1418
Conversation
Pull Request Test Coverage Report for Build 9094382462Details
💛 - Coveralls |
@jan-janssen Thanks for the format black commit! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I remember correctly one can get the eigenvector also via some post processing from phonopy even from a loaded job, so it might not be necessary to save them and rather just compute them on demand (not sure how long this takes anymore). But that would be a bigger change and this is self contained and works, so looks good to me.
@pmrv yes, you are right. But this involves executing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me - please go ahead and merge the pull request so we include the changes in the next release.
In order to calculate the projected DOS (either internally with phonopy or externally using a custom script), one needs the
eigenvectors
of the dynamical matrix at each (ideally irreducible) qpoint. This is by default hard-coded to beFalse
in pyiron. I add an additional input to allow to save these eigenvectors if necessary.Phonopy has 2(?) methods for the integration over the Brillouin zone: the
tetrahedron method
(phonopy default, hard coded in pyiron) and theGaussian smearing method
(sigma
calculated internally by phonopy). I also add an additional input to allow to change the default.