-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add OutcarCollectError and catch it in Vasp.collect #1394
Conversation
If an OUTCAR is present but does not contain NIONS the collect method breaks the Outcar objects raises an unexpected ValueError. This changes the error to a more specific one and correctly catches the error during collect.
Pull Request Test Coverage Report for Build 9225178252Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, still having a short test for this error would be great.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
If an OUTCAR is present but does not contain NIONS the collect method breaks the Outcar objects raises an unexpected ValueError.
This changes the error to a more specific one and correctly catches the error during collect.