Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lammps: use to_dict() rather than to_hdf() #1271

Merged
merged 10 commits into from
Dec 28, 2023
Merged

Lammps: use to_dict() rather than to_hdf() #1271

merged 10 commits into from
Dec 28, 2023

Conversation

jan-janssen
Copy link
Member

@jan-janssen jan-janssen commented Dec 26, 2023 •
edited
Loading

Introduce the to_dict() method to the LAMMPS job. Following the recent implementation in pyiron_base pyiron/pyiron_base#1263

@jan-janssen jan-janssen marked this pull request as draft December 26, 2023 16:08
@jan-janssen
Copy link
Member Author

waiting for the next_version of pyiron_base.

@jan-janssen jan-janssen reopened this Dec 26, 2023
@jan-janssen jan-janssen marked this pull request as ready for review December 26, 2023 17:17
@jan-janssen
Copy link
Member Author

jan-janssen commented Dec 26, 2023 •
edited
Loading

Issues are fixed.

@jan-janssen jan-janssen marked this pull request as draft December 26, 2023 22:02
@jan-janssen jan-janssen marked this pull request as ready for review December 26, 2023 23:34
@jan-janssen jan-janssen merged commit 6201dda into main Dec 28, 2023
25 checks passed
@delete-merged-branch delete-merged-branch bot deleted the lammps_fto_dict branch December 28, 2023 12:34
@pmrv pmrv mentioned this pull request Feb 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jan-janssen