Always use periodic_table.csv file embedded in the repo #1191
Conversation
setup.py
Outdated
| @@ -61,5 +61,5 @@ | |||
| 'structuretoolkit==0.0.11' | |||
| ], | |||
| cmdclass=versioneer.get_cmdclass(), | |||
|
|
|||
| package_data={'': ['_data/*.csv']}, | |||
There was a problem hiding this comment.
Is there a specific reason to name the folder _data rather than just data?
There was a problem hiding this comment.
Well, I considered this private to the repo. However, since there is no __init__ (at least not yet). It will not pop up in the dir of the package.
There was a problem hiding this comment.
Yes, I also do not expect there to be any __init__ in the data directory but on the root level of the repository I would prefer to have it as data rather than _data or .data.
|
I think the "proper" way to access package data is via pkgutil, then you can also hard code "pyiron_atomistics" as the package name rather than relying on |
|
@niklassiemer I guess it makes sense to release a new version of |
No description provided.