Polish macro creation #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
November 20, 2024 14:10
|
The current implementation has the limitation that it does not re-order the input fields which can lead to, in some cases, unintuitive macros, and in some edge cases, nonsensical macros. This functionaility should ideally be offloaded to |
|
Merging for now so that we have a working conda install from main. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create macros interactively using gui.
create_macro.pyis a placeholder till a further polished method is implemented inpyiron_workflow. Tested for some macros and seems stable. Further testing and bug reports from others are welcome. Current implementation does not replace nodes with a macro. Rather a macro is saved to file which has to be inserted into the workflow manually (after re-instantiation of thePyironFlowwidget). This step could be automated in the future when thetreeviewwidget is updated dynamically.